Repository navigation
Conversation
Eason09053360
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 11, 2026 10:39
This was referenced Sep 25, 2026
potiuk
added
the
closed because of open PR limit
Member
|
Hello @Eason09053360 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 33 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
This was referenced Sep 25, 2026
This was referenced Sep 25, 2026
Eason09053360
force-pushed
the
fix-tasks-clear-task-regex-substring-match
branch
from
October 20, 2026 11:03
358b2d4 to
d8e8d0f
Compare
henry3260
reviewed
Oct 21, 2026
The flag, its help text and the docs all promise a regular expression, but since apache#47360 removed regex support from partial_subset (to stop the REST API root parameter from being parsed as a regex) the CLI passed the pattern straight through and it was matched as a literal substring. Any pattern with metacharacters silently matched nothing and cleared nothing. Resolve the regex in the CLI, the only caller that promises one, and hand partial_subset a concrete set of task ids so the shared method keeps its non-regex contract. An invalid pattern now exits with a one-line error instead of a traceback.
A mistyped Dag id hid an invalid task pattern until the Dag id was fixed, and with --dag-regex every Dag file was parsed before the pattern error was reported.
Eason09053360
force-pushed
the
fix-tasks-clear-task-regex-substring-match
branch
from
October 21, 2026 14:26
c41cbe0 to
0dc3e59
Compare
henry3260
approved these changes
Oct 21, 2026
henry3260
left a comment
henry3260
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update!
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 21, 2026
apache#72941) * Fix tasks clear --task-regex matching as a plain substring The flag, its help text and the docs all promise a regular expression, but since apache#47360 removed regex support from partial_subset (to stop the REST API root parameter from being parsed as a regex) the CLI passed the pattern straight through and it was matched as a literal substring. Any pattern with metacharacters silently matched nothing and cleared nothing. Resolve the regex in the CLI, the only caller that promises one, and hand partial_subset a concrete set of task ids so the shared method keeps its non-regex contract. An invalid pattern now exits with a one-line error instead of a traceback. * Validate --task-regex before looking up the Dag A mistyped Dag id hid an invalid task pattern until the Dag id was fixed, and with --dag-regex every Dag file was parsed before the pattern error was reported. --------- (cherry picked from commit aee2d4d) Co-authored-by: Y-C <easoneason0905@gmail.com> Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 21, 2026
apache#72941) * Fix tasks clear --task-regex matching as a plain substring The flag, its help text and the docs all promise a regular expression, but since apache#47360 removed regex support from partial_subset (to stop the REST API root parameter from being parsed as a regex) the CLI passed the pattern straight through and it was matched as a literal substring. Any pattern with metacharacters silently matched nothing and cleared nothing. Resolve the regex in the CLI, the only caller that promises one, and hand partial_subset a concrete set of task ids so the shared method keeps its non-regex contract. An invalid pattern now exits with a one-line error instead of a traceback. * Validate --task-regex before looking up the Dag A mistyped Dag id hid an invalid task pattern until the Dag id was fixed, and with --dag-regex every Dag file was parsed before the pattern error was reported. --------- (cherry picked from commit aee2d4d) Co-authored-by: Y-C <easoneason0905@gmail.com> Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
airflow tasks clear -t/--task-regexis documented as a regex, but since #47360 dropped regex support frompartial_subset, the CLI has passed the pattern through as a plain substring match. A pattern such as'^runme_[02]$'silently clears nothing and exits 0, while--dag-regexon the same command still usesre.search.What
task_clearnow filters task ids withre.searchitself and passes the matched set topartial_subset, which stays non-regex for its API and UI callers. An invalid pattern exits with a one-lineInvalid --task-regexerror instead of a traceback. As in Airflow 2, an unescaped.now matches any character;--dag-regexcombined with--task-regexstill crashes and is tracked in #66884.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5.1) following the guidelines